Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not start TypeSpec Language Server when there is no workspace opened #5413

Merged
merged 25 commits into from
Jan 7, 2025

Conversation

RodgeFu
Copy link
Contributor

@RodgeFu RodgeFu commented Dec 19, 2024

Do not start TypeSpec Language Server when there is no workspace opened in vscode and update the Create TypeSpec project scenario to make sure there is not error notification popup complaining about LSP when checking compiler which would be confusing.

fixes: #5418

@RodgeFu RodgeFu added the ide Issues for VS, VSCode, Monaco, etc. label Dec 19, 2024
@azure-sdk
Copy link
Collaborator

azure-sdk commented Dec 19, 2024

All changed packages have been documented.

  • typespec-vscode
Show changes

typespec-vscode - fix ✏️

Do not start TypeSpec Language Server when there is no workspace opened

@azure-sdk
Copy link
Collaborator

You can try these changes here

🛝 Playground 🌐 Website 📚 Next docs 🛝 VSCode Extension

@RodgeFu RodgeFu added this pull request to the merge queue Jan 7, 2025
Merged via the queue into microsoft:main with commit 6e352d2 Jan 7, 2025
24 checks passed
@RodgeFu RodgeFu deleted the no-lsp-error-without-workspace branch January 7, 2025 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ide Issues for VS, VSCode, Monaco, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: LSP may show error notification when user creates TypeSpec project but no compiler installed yet
3 participants